docs: retrospective review of stories 1-1 to 1-5 + four deferred items#7
Merged
Merged
Conversation
Triaged findings into refactor-now / defer / discard per the cutover spec. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Items D-1 through D-4 from docs/superpowers/specs/2026-05-31-shipped-work-review.md: unreachable PydanticDecoder TypeError fallback, module-global lru_cache, opaque extensions forwarding, and Response.json() exception/charset handling. None block Epic 2; each names the story under which it becomes actionable. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/superpowers/specs/2026-05-31-shipped-work-review.md— first execution of the post-cutover superpowers flow. Triage: 0 refactor-now / 4 defer / 25 discard.docs/deferred-work.mdunder a new "Deferred from: retrospective review (2026-05-31)" section: unreachablePydanticDecoderTypeErrorfallback (D-1), module-globallru_cache(D-2), opaqueextensionsforwarding to httpx2 (D-3),Response.json()exception/charset handling (D-4). Each names the story under which it becomes actionable.The reviewer's verdict is that the shipped surface is in good shape: every CI-enforceable invariant grep passes, the Seam 4 exception ordering is correct, the exception contract is locked (keyword-only, MappingProxyType headers, pickle/deepcopy round-trip, userinfo redacted at
__repr__/__str__), and lazy client init is concurrency-safe with a test that exercises the race. The 25 discards are mostly verified duplicates of existingdeferred-work.mdentries plus a handful considered-and-rejected (StatusError-as-dataclass would break pickling;raise_for_status()is redundant for a 2xx Response; etc.).Per the report's recommendation, the planned post-review "refactor" task is empty — we go straight to Epic 2 (Story 2-1, middleware protocol) once this lands.
Test plan
docs/deferred-work.mdstill parses; new section sits at the top, existing entries unchanged.🤖 Generated with Claude Code